Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to allow developers to utilize full request API. #299

Merged
merged 2 commits into from
Jan 6, 2016
Merged

Added logic to allow developers to utilize full request API. #299

merged 2 commits into from
Jan 6, 2016

Conversation

Freyert
Copy link
Contributor

@Freyert Freyert commented Jan 5, 2016

These changes were made so that users can place arbitrary config values into the request field when configuring a Connection in order to manipulate configuration values for the request library.

Included is a very basic unit test that tests out the rawRequest function to ensure these values are passed to request correctly.

@panuhorsmalahti
Copy link
Contributor

Could add a simple documentation of this new feature to readme.MD? Otherwise looks good to me, 👍.

@Freyert
Copy link
Contributor Author

Freyert commented Jan 6, 2016

@panuhorsmalahti let me know what you think about the documentation.

@panuhorsmalahti
Copy link
Contributor

Looks good, 👍

panuhorsmalahti added a commit that referenced this pull request Jan 6, 2016
Added logic to allow developers to utilize full request API.
@panuhorsmalahti panuhorsmalahti merged commit 5e0b9ef into flatiron:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants